Conversation
…* to tmp-* Replace misleading 'console-' and 'aiven-' prefixes with 'tmp-' to clearly indicate these are temporary, TTL-based resources. Also switch from crc32 to sha256 for better collision resistance.
Users may provide the full Kubernetes resource name (e.g.
'valkey-myteam-cache' or 'opensearch-myteam-myindex') instead of just the
short instance name ('cache', 'myindex'). Strip the prefix to avoid
double-prefixing when Aivenator constructs the Aiven service name.
Contributor
|
I valkey og opensearch pakka så har vi |
…credentials Addresses review feedback to avoid duplicating the prefix logic. The canonical prefix definition now lives in each service package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiven-<type>-<hash>totmp-<type>-<hash>console-<type>-<hash>totmp-<type>-<hash>The old prefixes (
console-,aiven-) leaked internal implementation details and didn't communicate that these are temporary, TTL-based resources. Thetmp-prefix makes it immediately clear these are ephemeral.Affects all three credential types: Kafka, OpenSearch, and Valkey.