Bulk apply by thokra-nav · Pull Request #353 · nais/api

thokra-nav · 2026-03-11T12:19:21Z

No description provided.

internal/apply/apply.go

internal/apply/activitylog.go

internal/apply/apply.go

internal/graph/schema/apply.graphqls

internal/graph/apply.resolvers.go

thokra-nav · 2026-03-11T14:37:13Z

internal/rest/rest.go

 }

-func MakeRouter(ctx context.Context, pool *pgxpool.Pool, log logrus.FieldLogger, middlewares ...func(http.Handler) http.Handler) *chi.Mux {
+func MakeRouter(ctx context.Context, cfg Config) *chi.Mux {


Det er kanskje unødvendig å kjøre 2 http servere som begge eksponerer paths på ingressen. Vurdere om vi kan samle både http serveren i denne pakka og den som allerede eksisterer i http.go (den som /graphql) i en senere PR

internal/rest/rest.go

internal/apply/apply.go

internal/apply/client.go

thokra-nav · 2026-03-12T12:37:03Z

internal/apply/diff.go

+var ignoredTopLevelFields = map[string]bool{
+	"status": true,
+}
+
+// ignoredMetadataFields are metadata fields managed by the API server.
+var ignoredMetadataFields = map[string]bool{
+	"resourceVersion":            true,
+	"uid":                        true,
+	"generation":                 true,
+	"creationTimestamp":          true,
+	"managedFields":              true,
+	"selfLink":                   true,
+	"deletionTimestamp":          true,
+	"deletionGracePeriodSeconds": true,
+}


Vi bør kanskje ta en ekstra titt på dette. Vi kan kanskje også generelt ignorere endringer til .metadata?
Men av de ressursene som eksisterer i dag så er det noen som ikke har defaulting webhook, så kan være vi må justere litt på hvordan vi gjør diff

internal/apply/whitelist.go

Co-authored-by: Vegar Sechmann Molvig <vegar.sechmann.molvig@nav.no>

- Move resource activity log types to activitylog package - Add fallback transformer for unknown resource kinds - Unify changed field representation and string conversion - Update GraphQL schema and resolvers for new types - Require pre-shared key for team API in integration tests - Update apply endpoint to use path parameters for team and environment

Fix environment name field

Co-authored-by: Vegar Sechmann Molvig <vegar.sechmann.molvig@nav.no>

Use the mise-installed CodeFormat binary in the Lua fmt task instead of downloading a formatter at runtime.

Convert apply to a struct-based HTTP handler, perform team authorization before request parsing, and restore environmentName in per-resource results. NOTE: tests are currently not passing in this branch.

Move team impersonation client creation into kubernetes config and allow rest/apply wiring to override the dynamic client in integration tests. This keeps production behavior while making authorization outcomes deterministic in tests.

…ls in tests GitHubOIDC now accepts an issuer parameter, returns an error instead of silently degrading, and is passed as an optional field in rest.Config. Integration tests simply leave the field nil to skip the middleware.

server Co-authored-by: Vegar Sechmann Molvig <vegar.sechmann.molvig@nav.no>

Custom error message for psk auth Co-authored-by: Vegar Sechmann Molvig <vegar.sechmann.molvig@nav.no>

nais-team-app bot added the graphql-review-required label Mar 11, 2026