Conversation
Owner
mxpv
commented
Apr 7, 2026
mxpv
commented
- Moves composition logic to ./compose
- Removes bunch of clones.
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Extract prim index building, field resolution, and LIVERPS arc handling from Stage into PrimIndex::build() and PrimIndex::resolve_field(). Stage now delegates to these methods, keeping only caching, the query API, and traversal. Add LayerData type alias for Box<dyn AbstractData>. Reduce allocations: use Cow for prim path in arc resolution, remove identity replace_prefix call in add_remapped_nodes, unify reference and payload handling via add_arc_nodes to avoid intermediate clones, return HashMap from resolve_variant_selections, and replace cloning prim index cache with update_index + borrow pattern.
Move prim index, arc type, and find_layer tests from stage to compose/prim_index where the implementation now lives. Stage tests retain only the public API assertions (field resolution, children, traversal).
Use Cow to avoid allocations in the common prim field resolution path. Property fields pass a suffix that gets appended per-node; prim fields pass None and borrow the node path directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.