JSON config > add allow_non_descriptive_head_signs[until]

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GTFS parser's configuration by introducing new options to conditionally permit non-descriptive head signs for specific routes. This provides greater flexibility in handling agency data that might not conform to strict head sign descriptions, allowing for temporary or permanent exceptions through a centralized JSON configuration.

Highlights

• New Configuration Options: Introduced allow_non_descriptive_head_signs and allow_non_descriptive_head_signs_until to the RouteConfig to manage exceptions for head sign descriptions.
• Dynamic Head Sign Allowance: Updated DefaultAgencyTools to dynamically check the new RouteConfig for whether non-descriptive head signs are permitted for a given route, including support for time-bound allowances.
• Improved Data Handling Flexibility: Enabled the ability to configure specific routes to temporarily or permanently allow non-descriptive head signs, providing more flexibility for processing diverse transit agency data.

Changelog

• src/main/java/org/mtransit/parser/DefaultAgencyTools.java
  • Modified the allowNonDescriptiveHeadSigns method to retrieve its value from the RouteConfig instead of returning a fixed false.
• src/main/java/org/mtransit/parser/config/gtfs/data/RouteConfig.kt
  • Added allowNonDescriptiveHeadSigns as a map of route IDs to booleans.
  • Added allowNonDescriptiveHeadSignsUntil as a map of route IDs to date strings, allowing for temporary exceptions.
  • Implemented a new allowNonDescriptiveHeadSigns function that checks both the permanent and temporary configuration options based on the current date and route ID.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a configuration option to allow non-descriptive head signs for specific routes, either indefinitely or until a certain date. The changes involve updating RouteConfig.kt with new properties and a function to check the configuration, and modifying DefaultAgencyTools.java to use this new logic. My review includes a suggestion to refactor duplicated date validation logic into a helper function to improve code maintainability.