JSON configs > add extended_target_route_type_id & stop_time_excludes

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the GTFS parser's configuration flexibility by introducing new JSON-based options. It allows for the definition of an extended route type at the agency level and provides a robust mechanism to filter and exclude specific stop times based on configurable headsign patterns, leading to more precise data processing and improved control over GTFS data ingestion.

Highlights

• Extended Target Route Type ID: Introduced an optional extended_target_route_type_id field in the AgencyConfig JSON, allowing agencies to specify an extended route type. This value is now accessible via DefaultAgencyTools.getAgencyExtendedRouteType().
• Stop Time Exclusion Configuration: Added an optional stop_time_excludes field to the RouteConfig JSON. This field accepts a list of StopTimeFilter objects, enabling the exclusion of specific stop times based on their headsigns using regular expressions.
• Flexible Stop Time Exclusion Logic: The DefaultAgencyTools.excludeStopTime() method was updated to first check for exclusions defined in the RouteConfig's stop_time_excludes before applying its default exclusion rules.
• New StopTimeFilter Data Class: A new StopTimeFilter data class was added within RouteConfig.kt to define the structure for stop time exclusion rules, including a stop_time_headsign_regex and an ignore_case flag.

Changelog

• src/main/java/org/mtransit/parser/DefaultAgencyTools.java
  • Updated getAgencyExtendedRouteType() to retrieve the extendedTargetRouteTypeId from Configs.getAgencyConfig().
  • Modified excludeStopTime() to first consult Configs.getRouteConfig().excludeStopTime() for exclusions before applying default logic.
• src/main/java/org/mtransit/parser/config/gtfs/data/AgencyConfig.kt
  • Added extendedTargetRouteTypeId as an optional integer field, serialized as extended_target_route_type_id.
• src/main/java/org/mtransit/parser/config/gtfs/data/RouteConfig.kt
  • Imported GStopTime.
  • Added stopTimeExcludes as an optional list of StopTimeFilter objects, serialized as stop_time_excludes.
  • Introduced StopTimeFilter data class with stopTimeHeadsignRegex and ignoreCase properties.
  • Implemented a lazy property _stopTimeExcludes to compile regex patterns from stopTimeExcludes.
  • Added excludeStopTime(GStopTime) method to evaluate stop time exclusions based on configured regex patterns.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two new configuration options: extended_target_route_type_id for agency configuration and stop_time_excludes for route configuration. The changes correctly implement the logic to use these new settings.

My review includes a critical fix for a potential crash in AgencyConfig.kt due to an incorrect property declaration for an optional field. I've also suggested a refactoring in RouteConfig.kt to make the code more concise and idiomatic.