RMST-364 - Implementing cache-control header for git-reader routes#1224
Merged
alexcottner merged 9 commits intomainfrom Mar 24, 2026
Merged
RMST-364 - Implementing cache-control header for git-reader routes#1224alexcottner merged 9 commits intomainfrom
alexcottner merged 9 commits intomainfrom
Conversation
leplatrem
reviewed
Mar 23, 2026
leplatrem
reviewed
Mar 24, 2026
leplatrem
approved these changes
Mar 24, 2026
Contributor
leplatrem
left a comment
There was a problem hiding this comment.
Looks good 👌
While reading the diff, I was thinking we could have a helper like add_cache_header(response, settings, "long") but it adds one indirection and I don't think it's justified
Regarding the middleware, I think it's the right pattern. Setting the env var with monkeypath is the only way if we want to set it to tempdir
Contributor
|
We currently list settings in the README, maybe we could remove them and keep |
Contributor
Author
|
Good call. Also realizing that our formatting in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RMST-364
Adding cache rules to git-reader. This works similarly to what we have in the v1 readers, but I tried to simplify it into the main cache rules that we have.
Uses our existing Settings pattern.
Updated documentation.