Improve patternDetection performance#877
Open
marcustyphoon wants to merge 6 commits intomozilla:mainfrom
Open
Conversation
most of these are actually broken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the large number of CSS selectors that are included in the patternDetection query, this extension can be fairly performance intensive on complex pages. However, as documented in the comments, many of the selectors are designed for a particular site, and thus don't need to be run on every site. This PR filters some of them out by filtering on
window.location.hostname.There may be cases where one site's login pattern selector coincidentally matches another site's login form, so there is some potential for loss of current functionality here, of course.
Edit: Oh, hey, an issue. Mostly resolves #544, but I do not know exactly which selectors need to be left, so I was much more conservative with the list than that issue suggests.