Skip to content

Handle beta version not yet updated in product-details#2822

Open
DonalMe wants to merge 1 commit intomozilla:masterfrom
DonalMe:fix-beta-version-not-updated
Open

Handle beta version not yet updated in product-details#2822
DonalMe wants to merge 1 commit intomozilla:masterfrom
DonalMe:fix-beta-version-not-updated

Conversation

@DonalMe
Copy link
Contributor

@DonalMe DonalMe commented Mar 3, 2026

For a few days after each release, product-details still reports the old beta version (e.g. release=149, beta=149, nightly=150) because no Fx150 beta builds have landed yet. This caused get_checked_versions() to fail its consecutive-version check and return {}, silently disabling the regression_set_status_flags rule for that window. This has always been a problem, but the window is longer since we don't ship beta until a few days after merge day.

When release == beta and nightly == release + 1, we now treat beta as nightly (N+1) so the rule can continue running.

This is a naive fix, but it might help re-evaluate this logic.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

For a few days after each release, product-details still reports the old
beta version (e.g. release=149, beta=149, nightly=150) because no Fx150
beta builds have landed yet. This caused get_checked_versions() to fail
its consecutive-version check and return {}, silently disabling the
regression_set_status_flags rule for that window.

When release == beta and nightly == release + 1, we now treat beta as
nightly (N+1) so the rule can continue running.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts get_checked_versions() to keep Bugbot’s version-dependent rules running during the post-release window where product-details reports a stale beta version.

Changes:

  • Detect the release == beta and nightly == release + 1 “stale beta” scenario from product-details.
  • Treat beta as nightly (N+1) for this window and return the adjusted versions map (instead of returning {}).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

"Beta version not yet updated in product-details, treating beta as %d",
v[2],
)
versions["beta"] = str(v[2])
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this special-case branch you return versions without re-checking that product-details nightly (v[2]) matches the nightly version inferred from Bugzilla (the validation done in the consecutive-versions branch). If Bugzilla has already advanced but product-details is still stale, this will re-enable rules with inconsistent version data. Consider running the same Bugzilla mismatch check here (and returning {} on mismatch) before returning the adjusted versions.

Suggested change
versions["beta"] = str(v[2])
versions["beta"] = str(v[2])
nightly_bugzilla = get_nightly_version_from_bz()
if v[2] != nightly_bugzilla:
logger.info("Versions mismatch between Bugzilla and product-details")
return {}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants