Skip to content

fix: avoid initializing syncer at node startup in sequencer mode#917

Merged
FletcherMan merged 1 commit intorelease/0.5.xfrom
fix/node-startup-no-syncer-init
Mar 16, 2026
Merged

fix: avoid initializing syncer at node startup in sequencer mode#917
FletcherMan merged 1 commit intorelease/0.5.xfrom
fix/node-startup-no-syncer-init

Conversation

@tomatoishealthy
Copy link
Contributor

Previously, the syncer was eagerly initialized just to reuse its L1 client for L1 sequencer components and BlockTagService. This required a deposit contract config that is unnecessary for non-validator nodes, causing mainnet nodes to fail on startup.

Now we dial the L1 client directly from the l1.rpc flag and defer syncer creation to a lazy factory (newSyncerFunc) that only runs when the executor actually needs it.

Previously, the syncer was eagerly initialized just to reuse its L1
client for L1 sequencer components and BlockTagService. This required
a deposit contract config that is unnecessary for non-validator nodes,
causing mainnet nodes to fail on startup.

Now we dial the L1 client directly from the l1.rpc flag and defer
syncer creation to a lazy factory (newSyncerFunc) that only runs when
the executor actually needs it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tomatoishealthy tomatoishealthy requested a review from a team as a code owner March 16, 2026 06:48
@tomatoishealthy tomatoishealthy requested a review from twcctop March 16, 2026 06:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18f1fdd1-a546-4bd6-8e6e-e799d492f30f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/node-startup-no-syncer-init
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FletcherMan FletcherMan merged commit 1d16588 into release/0.5.x Mar 16, 2026
26 checks passed
@FletcherMan FletcherMan deleted the fix/node-startup-no-syncer-init branch March 16, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants