Skip to content

feat(chainspec): set Jade fork activation timestamps#51

Merged
panos-xyz merged 1 commit intomainfrom
feat/jade-fork-activation
Mar 16, 2026
Merged

feat(chainspec): set Jade fork activation timestamps#51
panos-xyz merged 1 commit intomainfrom
feat/jade-fork-activation

Conversation

@panos-xyz
Copy link
Contributor

@panos-xyz panos-xyz commented Mar 13, 2026

Summary

  • Set Jade fork activation timestamp for Hoodi (chain 2910): 1774418400 (2026-03-25 06:00 UTC)
  • Set Jade fork activation timestamp for Mainnet (chain 2818): 1775628000 (2026-04-08 06:00 UTC)
  • Added corresponding hardfork activation tests for both networks

Test plan

  • cargo test -p morph-chainspec — all 32 tests passed

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added Jade hardfork support to network configuration.
  • Tests

    • Added test coverage for Jade hardfork activation verification across networks.

Hoodi (chain 2910): 1774418400 (2026-03-25 06:00 UTC)
Mainnet (chain 2818): 1775628000 (2026-04-08 06:00 UTC)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a77dda7-2019-4901-bf64-0e70ffe45b17

📥 Commits

Reviewing files that changed from the base of the PR and between 5843ee6 and 638c453.

📒 Files selected for processing (4)
  • crates/chainspec/res/genesis/hoodi.json
  • crates/chainspec/res/genesis/mainnet.json
  • crates/chainspec/src/morph.rs
  • crates/chainspec/src/morph_hoodi.rs

📝 Walkthrough

Walkthrough

A new hardfork timestamp parameter "jadeTime" was added to two genesis configuration files (hoodi and mainnet) with distinct values, and corresponding test cases were added to verify the Jade hardfork activation boundaries for each network.

Changes

Cohort / File(s) Summary
Genesis Configuration Updates
crates/chainspec/res/genesis/hoodi.json, crates/chainspec/res/genesis/mainnet.json
Added "jadeTime" timestamp key to the config section of each genesis file with network-specific values (1774418400 for hoodi, 1775628000 for mainnet).
Jade Hardfork Activation Tests
crates/chainspec/src/morph.rs, crates/chainspec/src/morph_hoodi.rs
Added boundary tests for Jade activation, verifying that is_jade_active_at_timestamp() correctly returns false before the activation timestamp and true at/after the activation timestamp.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • anylots

Poem

🐰 Hop, hop, jade's here to stay,
New timestamps light the way,
Genesis files now shine so bright,
With activation tests done right!
The chain progresses, all is well,
New hardforks have a tale to tell!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: setting Jade fork activation timestamps across multiple chainspec configurations and adding corresponding tests.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/jade-fork-activation
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chengwenxi
Copy link
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@panos-xyz panos-xyz merged commit daeebbb into main Mar 16, 2026
9 checks passed
@panos-xyz panos-xyz deleted the feat/jade-fork-activation branch March 16, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants