chore: add architecture input to deploy workflows#232
Merged
JesperTerkelsen merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
Add the `architecture` input parameter to deploy-kotlin, deploy-generic, deploy-generic-v2, and deploy-python workflows. This allows callers to explicitly request ARM64 runners for test jobs during deployments. The architecture parameter is forwarded to component-test-kotlin and component-test-python sub-workflows where applicable. Default remains x64 for backwards compatibility - callers can opt-in to arm64. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
brroMonta
approved these changes
Feb 17, 2026
Contributor
|
@JesperTerkelsen question
how do we validate? Shouldn't we just flip the default and then fix/pass x64 as arg on the failing (if any) projects? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
architectureinput parameter to deploy workflows, enabling callers to opt-in to ARM64 runners for test jobs during deployments.Changes
architectureinput, forwarded tocomponent-test-kotlin.ymlarchitectureinput, forwarded tocomponent-test-python.ymlarchitectureinput (for future use)architectureinput (for future use)Why
As part of the ARM64 runner migration, we've already migrated 37 repos' PR/test/code-analysis workflows to ARM64. The deploy workflows were the remaining gap - they accept
runner-sizebut notarchitecture, so test jobs during deploys always defaulted to x64.Impact
x64- no behavior change for existing callersarchitecture: "arm64"in their deploy workflowwith:blocksarm64in a follow-up PRRelated
🤖 Generated with Claude Code