Remove deprecated methods __find_args__ and multi_arged?#275
Open
johnnyshields wants to merge 10 commits intomongoid:masterfrom
Open
Remove deprecated methods __find_args__ and multi_arged?#275johnnyshields wants to merge 10 commits intomongoid:masterfrom
johnnyshields wants to merge 10 commits intomongoid:masterfrom
Conversation
Member
Author
|
@dblock please review. Not tests because no functionality changed, it's just an internal refactor. |
Member
Author
|
D'oh there's a legit failure on Mongoid 9.0 re: embedded documents, unrelated to this PR. This is fine to merge but will need to investigate it. |
Collaborator
|
Let's not merge without passing CI. Maybe remove Mongoid 9 for now and add it in another PR with a fix? |
Collaborator
|
I got #277 with CI green, merge that and rebase @johnnyshields ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods fill the logs with deprecation warnings in Mongoid 9.