Ignore empty address line 2 in formattedAddress#6
Open
danielr18 wants to merge 2 commits intomoneals:masterfrom
Open
Ignore empty address line 2 in formattedAddress#6danielr18 wants to merge 2 commits intomoneals:masterfrom
danielr18 wants to merge 2 commits intomoneals:masterfrom
Conversation
Pull Request Test Coverage Report for Build 111
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the following address
12939 Live Oak Street,, San Antonio, TX 78253should return a formatted address like12939 Live Oak St, San Antonio, TX 78253rather than12939 Live Oak St, , San Antonio, TX 78253.If a second address line is parsed and determined to be empty, I would prefer to ignore. What's your opinion?