Revert "fix(monad): exclude blob suites from MONAD_EIGHT (#15)"#20
Draft
pdobacz wants to merge 1 commit intoforks/monad_ninefrom
Draft
Revert "fix(monad): exclude blob suites from MONAD_EIGHT (#15)"#20pdobacz wants to merge 1 commit intoforks/monad_ninefrom
pdobacz wants to merge 1 commit intoforks/monad_ninefrom
Conversation
This reverts commit 8ee8f94.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately #15 broke running of tests with
monad. This is a hot take but it seems that when RLP decoding the header it misses the blob-related header fields. I'm not sure this is a matter ofmonad's RLP decoding or the #15 introducing an unexpected format of block headers.Opening as DRAFT, only so that a release can be cut with correctly filling tests. CC @haythemsellami
Problem Description
When you run the tests with
monad'smonad_ethereum_test, you'll get:Currently, the decoding code seems to first expect
blobGasUsedin the header:and then
requestsHash. In the test block headers, only the latter field is present:which I think leads to the decoder interpreting
requestsHashasblobGasUsedleading to an overflow error.