feat: Add RequestIdGenerator for custom request ID generation#732
Open
rhtnr wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
feat: Add RequestIdGenerator for custom request ID generation#732rhtnr wants to merge 1 commit intomodelcontextprotocol:mainfrom
rhtnr wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Adds support for configuring custom request ID generators, enabling compatibility with MCP servers that require specific ID formats (e.g., numeric-only IDs). Changes: - Add RequestIdGenerator functional interface with factory methods for default (UUID-prefixed) and incremental (numeric) generators - Update McpClientSession to accept a custom RequestIdGenerator - Add requestIdGenerator() builder methods to McpClient.SyncSpec and McpClient.AsyncSpec - Add comprehensive tests for custom ID generators
Contributor
|
This is actually a nice addition, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #703
Adds support for configuring custom request ID generators, enabling compatibility with MCP servers that require specific ID formats (e.g., numeric-only IDs like the Snowflake MCP server).
Changes
RequestIdGeneratorfunctional interface inio.modelcontextprotocol.specwith:generate()method for creating unique request IDsofDefault()factory method for UUID-prefixed incrementing IDs (existing behavior)ofIncremental()factory method for simple numeric IDsMcpClientSessionto accept a customRequestIdGeneratorrequestIdGenerator()builder methods to bothMcpClient.SyncSpecandMcpClient.AsyncSpecUsage Example
Backward Compatibility
This change is fully backward compatible:
requestIdGenerator()method is optionalTest plan