fix #724, restore compliance to 2025-11-25 spec#725
Open
overheadhunter wants to merge 5 commits intomodelcontextprotocol:mainfrom
Open
fix #724, restore compliance to 2025-11-25 spec#725overheadhunter wants to merge 5 commits intomodelcontextprotocol:mainfrom
overheadhunter wants to merge 5 commits intomodelcontextprotocol:mainfrom
Conversation
overheadhunter
changed the title
valfirst
approved these changes
Dec 17, 2025
maff
reviewed
Dec 18, 2025
Comment on lines
409
to
410
| @JsonInclude(JsonInclude.Include.NON_ABSENT) | ||
| public record Sampling() { |
There was a problem hiding this comment.
According to the spec, sampling can contain values as well which would lead to the same issue as for the elicitation form. I'd suggest to add the ignore properties annotation here as well.
…1-25 spec
Update the ClientCapabilities.Elicitation record to accept optional "form"
and "url" fields as defined in the MCP 2025-11-25 specification.
Previously, deserializing an InitializeRequest with
`{"capabilities":{"elicitation":{"form":{}}}}` would fail with
UnrecognizedPropertyException because the Elicitation record was empty.
Changes:
- Add nested Form and Url marker records to Elicitation
- Add no-arg constructor for backward compatibility (serializes to {})
- Add elicitation(boolean form, boolean url) builder method
- Add comprehensive tests for deserialization and serialization
Fixes modelcontextprotocol#724
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #724, ignore unknown values during deserialization of
ClientCapabilities.ElicitationMotivation and Context
This fixes a deserialization issue in the initialization request sent from clients using the
2025-11-25protocol.How Has This Been Tested?
Test added
Breaking Changes
No, deserialization is now less strict.
Types of changes
Checklist
existing tests* pass locally* I had local issues with starting
docker.io/tzolov/mcp-everything-server:v3used in one of the tests. Up until this test, everything was green.Additional context
see #724