Fix Space Exploration issue with Classes#556
Open
Qatavin wants to merge 3 commits intomodded-factorio:devfrom
Open
Fix Space Exploration issue with Classes#556Qatavin wants to merge 3 commits intomodded-factorio:devfrom
Qatavin wants to merge 3 commits intomodded-factorio:devfrom
Conversation
This one line prevents Classes from loading with Space Exploration, since SE expects the character to have "icon" defined. Instead, we have "icons". But "icons" overrides "icon", so this is functionally the same.
Contributor
|
I've reported this here: https://discord.com/channels/419526714721566720/1487665922637562007 I don't like the solution posted as this results in log file warnings. 
|
Collaborator
Author
|
Different solution. Restored the icon = nil at the top of character.lua, then added the icon back at the bottom of the file for SE to use. Then removed it again in final fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one line prevents Classes from loading with Space Exploration, since SE expects the character to have "icon" defined. Instead, we have "icons". But "icons" overrides "icon", so this is functionally the same.