Make peer manager use a provided RNG instead of creating a new one each time#2025
Draft
ImplOfAnImpl wants to merge 1 commit intop2p_specify_min_core_versionfrom
Draft
Make peer manager use a provided RNG instead of creating a new one each time#2025ImplOfAnImpl wants to merge 1 commit intop2p_specify_min_core_versionfrom
ImplOfAnImpl wants to merge 1 commit intop2p_specify_min_core_versionfrom
Conversation
ImplOfAnImpl
force-pushed
the
p2p_pass_rng_to_peer_manager
branch
from
9659c1c to
12ba705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a bunch of places inside the peer manager where
make_pseudo_rng()was called ad-hoc, the RNG is now passed from the outside, to make the potential test failures reproducible.P.S. there are still some calls to
make_pseudo_rngoutside ofp2p/src/peer_manager.