New hidden node option: --p2p-min-peer-software-version#2024
Draft
ImplOfAnImpl wants to merge 1 commit intomasterfrom
Draft
New hidden node option: --p2p-min-peer-software-version#2024ImplOfAnImpl wants to merge 1 commit intomasterfrom
--p2p-min-peer-software-version#2024ImplOfAnImpl wants to merge 1 commit intomasterfrom
Conversation
ImplOfAnImpl
commented
Mar 12, 2026
| Disconnect a peer given its id. | ||
|
|
||
| If it was an outbound connection, the peer address will be removed from the peer database, | ||
| and if the connection was inbound, the address will be kept. |
Contributor
Author
There was a problem hiding this comment.
FYI: I haven't changed this. It's the original behavior, I just decided to document it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the option is specified and the peer's version is smaller, the peer will be disconnected immediately and discouraged.
The main use case for this is the fork detection script, where it can prevent it from connecting to legacy nodes (pre-1.1.0 for testnet and pre-1.2.0 for mainnet), which are already known to be on a fork.