chore: removed custom pre_dispatch for pallet_midnight#1235
Open
chore: removed custom pre_dispatch for pallet_midnight#1235
Conversation
7eb8868 to
21da1b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Non-functional refactor.
pallet_midnightno longer overridesValidateUnsigned::pre_dispatch; it uses the Substrate trait default, which forwards tovalidate_unsigned(TransactionSource::InBlock, call)and maps the result toOk(())/TransactionValidityError.To keep behavior identical to the old custom
pre_dispatch,validate_unsignednow branches onTransactionSource: the in-block path uses the real block context andLedgerApi::validate_guaranteed_execution(what the removedpre_dispatchdid); the local/external path keeps the existing pool validation (LedgerApi::validate_transaction, adjustedtblock, tags, longevity, etc.). No change to what the runtime accepts or rejects—only where that logic lives so the defaultpre_dispatchis correct.📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links