Skip to content

fix(review): exclude current branch from base branch picker#5

Draft
middleDuckAi wants to merge 4 commits intoupstream-main-20260324from
middleDuck/codex-12942-review-base-branch-picker-includes-current
Draft

fix(review): exclude current branch from base branch picker#5
middleDuckAi wants to merge 4 commits intoupstream-main-20260324from
middleDuck/codex-12942-review-base-branch-picker-includes-current

Conversation

@middleDuckAi
Copy link
Copy Markdown
Owner

@middleDuckAi middleDuckAi commented Mar 24, 2026

Summary

  • exclude the currently checked out branch from the review base-branch picker
  • mirror the fix in both codex-tui and codex-tui-app-server
  • add deterministic regression tests with a temporary git repo fixture

Why

  • the picker currently includes the active branch, which is not a valid base-branch choice for the review flow

Testing

  • cargo test -p codex-tui review_branch_picker_excludes_current_branch
  • cargo test -p codex-tui-app-server review_branch_picker_excludes_current_branch
  • just fix -p codex-tui
  • just fix -p codex-tui-app-server
  • CARGO_TARGET_DIR=/tmp/codex-target-12942-tui-full cargo test -p codex-tui
  • CARGO_TARGET_DIR=/tmp/codex-target-12942-app-full cargo test -p codex-tui-app-server

jif-oai and others added 4 commits March 24, 2026 11:01
Add a `list_agents` for multi-agent v2, optionally path based

This return the task and status of each agent in the matched path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants