fix(tui): render file links with literal spaces#4
Draft
middleDuckAi wants to merge 1 commit intoupstream-main-20260324from
Draft
fix(tui): render file links with literal spaces#4middleDuckAi wants to merge 1 commit intoupstream-main-20260324from
middleDuckAi wants to merge 1 commit intoupstream-main-20260324from
Conversation
b3adef7 to
9dd069e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file://local link targetscodex-tuiandcodex-tui-app-serverWhy
Issue openai#14688 reports that local
file://links with literal spaces degrade to plain text becauseUrl::parserejects the raw target. That makes valid local references render inconsistently compared with already-encoded file links.This change adds a narrow space-encoding fallback for
file://parsing only, so the local-link renderer still shows the styled target path.Testing
cargo fmt --allcargo test -p codex-tui file_link_with_literal_spaces_uses_target_pathcargo test -p codex-tui-app-server file_link_with_literal_spaces_uses_target_pathNotes
file://parsing gets a space-encoding fallback.