fix(exec): fail on missing explicit resume targets#3
Draft
middleDuckAi wants to merge 2 commits intoupstream-main-20260324from
Draft
fix(exec): fail on missing explicit resume targets#3middleDuckAi wants to merge 2 commits intoupstream-main-20260324from
middleDuckAi wants to merge 2 commits intoupstream-main-20260324from
Conversation
2d1eb4e to
7a45071
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex exec resume <id>from silently creating a new thread when the requested target is missingresume --lastbehavior unchanged when there is no recorded thread to resumeWhy
Issues openai#15538 and openai#15539 both come from the same fallback: when an explicit resume target cannot be resolved locally,
codex exec resumewas falling through tothread/startand creating a new thread.This change keeps the fallback for
resume --last, but makes explicitresume <id>fail clearly withSession not found: <id>.Testing
cargo fmt --allcargo test -p codex-exec resolve_resume_targetcargo test -p codex-exec exec_resume_by_missing_id_fails_without_starting_new_sessioncargo test -p codex-exec exec_resume_by_ephemeral_id_fails_without_starting_new_sessionNotes