fix(exec): align exec help usage with parser#1
Draft
middleDuckAi wants to merge 1 commit intoupstream-main-20260324from
Draft
fix(exec): align exec help usage with parser#1middleDuckAi wants to merge 1 commit intoupstream-main-20260324from
middleDuckAi wants to merge 1 commit intoupstream-main-20260324from
Conversation
3e7487c to
9089ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex exec --helpwith the actual parser contractexecinvocation forms instead of a phantom second positionalexechelp outputWhy
Issue openai#15535 reports that
codex exec --helpadvertisesUsage: codex exec [OPTIONS] [PROMPT] [COMMAND], but the parser rejects a second positional argument. That makes the help output misleading for both humans and automation.This change keeps parser behavior unchanged and fixes the contract shown in help instead:
codex exec [OPTIONS] [PROMPT]codex exec [OPTIONS] <COMMAND> [ARGS]Testing
cargo fmt --all --checkcargo run -p codex-cli -- exec --help | sed -n '1,20p'cargo test -p codex-cli exec_help_does_not_advertise_a_second_positionalcargo test -p codex-cli exec_resumeprintf '' | cargo run -p codex-cli -- exec --ephemeral --skip-git-repo-check --color never - falseNotes
[PROMPT] [COMMAND].