Draft
Conversation
anthonykim1
changed the title
anthonykim1
commented
Feb 3, 2026
| } else { | ||
| context.environmentVariableCollection.delete('PYTHONSTARTUP'); | ||
| context.environmentVariableCollection.delete('PYTHON_BASIC_REPL'); | ||
| context.environmentVariableCollection.description = new MarkdownString( |
Author
There was a problem hiding this comment.
@Tyriar Not sure if Im doing something wrong here.. maybe this is bug in env collection??
I noticed when we remove the contribution to environment variable, it doesnt consider description if I try to set them:
Weird bc description showed up when replacing these variable.. just not when deleting these variables.
anthonykim1
added
debt
Tyriar
requested changes
Feb 3, 2026
Comment on lines
24
to
+29
| context.environmentVariableCollection.replace('PYTHONSTARTUP', destPath.fsPath); | ||
| // When shell integration is enabled, we disable PyREPL from cpython. | ||
| // When shell integration is enabled, we disable PyREPL from cpython. | ||
| context.environmentVariableCollection.replace('PYTHON_BASIC_REPL', '1'); | ||
| context.environmentVariableCollection.description = new MarkdownString( | ||
| Interpreters.shellIntegrationEnvVarCollectionDescription, | ||
| ); |
Member
There was a problem hiding this comment.
It's also used here:
vscode-python/src/client/terminals/envCollectionActivation/service.ts
Lines 408 to 415 in 0b477a3
There's meant to only be a single description to cover everything, but the above also uses scoped and I'm not sure how that interacts here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #25733
Now description show when contributing.. but not when deleting? See below
