Fix createTerminal command to prompt for project selection in multiroot workspaces#1036
Draft
Fix createTerminal command to prompt for project selection in multiroot workspaces#1036
Conversation
Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Python: Create Terminal for multiroot workspaces
Fix createTerminal command to prompt for project selection in multiroot workspaces
Dec 8, 2025
Member
|
@copilot secondly fix merge conflicts for the unit test file |
- Add explicit early return when user cancels project selection - Resolve merge conflicts by updating imports to match main branch - Replace manual thenable setup with setupNonThenable helper - Update helper.ts from main branch to include new setupNonThenable function - Use existing directories (/tmp, /home) in tests to avoid fs mocking issues Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
Contributor
Author
... Fixed both issues in commit 122bb6f: ESC Bug: Made the early return explicit when user cancels - changed from Merge Conflicts: Resolved by:
All 250 unit tests passing, including the 5 new Create Terminal tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Plan for Multiroot Create Terminal Support
Summary
Successfully implemented multiroot workspace support for the "Python: Create Terminal" command and addressed feedback.
Changes in This Update:
Bug Fix: ESC Cancellation
if (pw)toif (!pw) return undefined;to make early return explicit when user cancelsMerge Conflict Resolution
setupNonThenablefunctionenv.setup((e: any) => e.then)...) withsetupNonThenable(env)helperAll Tests Passing
✅ 250 tests passing
✅ All Create Terminal Command tests passing (5/5)
Behavior:
Before: When Python extension called
python-envs.createTerminal, it would directly create a terminal without checking for multiple projects. ESC handling was implicit.After:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.