Skip to content

StyleCop upgrade and many warning was resolved or disabled#261

Open
soroshsabz wants to merge 8 commits intomicrosoft:mainfrom
soroshsabz:master
Open

StyleCop upgrade and many warning was resolved or disabled#261
soroshsabz wants to merge 8 commits intomicrosoft:mainfrom
soroshsabz:master

Conversation

@soroshsabz
Copy link
Copy Markdown

ITNOA

  • I update StyleCop and disable some terrible warnings
  • I add some check main thread for better compatibility in Async era

@soroshsabz
Copy link
Copy Markdown
Author

@adrianvmsft Please review my PR.

thanks :)

@soroshsabz
Copy link
Copy Markdown
Author

Some great notes about VS Threading can found in VS Threading Cookbook

@soroshsabz
Copy link
Copy Markdown
Author

@adrianvmsft after one day, CI is not reported yet, Did you can run CI manually?

thanks

@soroshsabz
Copy link
Copy Markdown
Author

@adrianvmsft Did you have plan to review it? I have another PR for #257 and I want to create it after this

thanks

@soroshsabz
Copy link
Copy Markdown
Author

@adrianvmsft Did you can review this PR?

thanks

@soroshsabz
Copy link
Copy Markdown
Author

@adrianvmsft Why CI does not work?

@soroshsabz
Copy link
Copy Markdown
Author

@adrianvmsft Did you can review this PR?

thanks

1 similar comment
@soroshsabz
Copy link
Copy Markdown
Author

@adrianvmsft Did you can review this PR?

thanks

@soroshsabz
Copy link
Copy Markdown
Author

Any update?

@soroshsabz
Copy link
Copy Markdown
Author

soroshsabz commented Feb 17, 2023

@ttstanley @adrianvmsft please review this PR

I update this PR, and resolve all conflicts.

@soroshsabz
Copy link
Copy Markdown
Author

soroshsabz commented Feb 17, 2023

@ttstanley Did you can review this PR, and if this is okey, merge it?

thanks

@soroshsabz
Copy link
Copy Markdown
Author

@ttstanley @adrianvmsft any update?

@soroshsabz
Copy link
Copy Markdown
Author

@ttstanley @adrianvmsft any update?

@soroshsabz
Copy link
Copy Markdown
Author

@ttstanley @adrianvmsft Any update?

thanks

ttstanley pushed a commit that referenced this pull request Nov 14, 2024
Extend default timeout for APIScan job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant