Skip to content

Comments

fix: Subclass sklearn.model_selection._RepeatedSplits and BaseShuffleSplit from BaseCrossValidator#349

Merged
debonte merged 4 commits intomicrosoft:mainfrom
effigies:fix/cv-hierarchy
Feb 13, 2025
Merged

fix: Subclass sklearn.model_selection._RepeatedSplits and BaseShuffleSplit from BaseCrossValidator#349
debonte merged 4 commits intomicrosoft:mainfrom
effigies:fix/cv-hierarchy

Conversation

@effigies
Copy link
Contributor

This permits RepeatedKFold and other repeated split cross validators to be used when BaseCrossValidator is accepted. Additionally, BaseShuffleSplit follows the BaseCrossValidator protocol, so subclassing permits dropping many redundant unions.

@effigies
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Stanford University"

@debonte debonte merged commit 3d1d1d2 into microsoft:main Feb 13, 2025
3 checks passed
@debonte
Copy link
Contributor

debonte commented Feb 13, 2025

@effigies, thanks for the contribution!

@effigies effigies deleted the fix/cv-hierarchy branch February 13, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants