Update isort and black in run_formatters script to Ruff#344
Merged
debonte merged 2 commits intomicrosoft:mainfrom Mar 25, 2025
Merged
Conversation
Avasam
force-pushed
the
Update-isort-and-black-in-run_formatters-script-to-Ruff
branch
from
7163e13 to
3b22754
Compare
Avasam
force-pushed
the
Update-isort-and-black-in-run_formatters-script-to-Ruff
branch
from
3b22754 to
3581030
Compare
debonte
approved these changes
Jan 30, 2025
Contributor
debonte
left a comment
debonte
left a comment
There was a problem hiding this comment.
Renaming to use "hygiene" instead of "format" sounds good to me.
Avasam
force-pushed
the
Update-isort-and-black-in-run_formatters-script-to-Ruff
branch
2 times, most recently
from
3b22754 to
c360cc9
Compare
Avasam
force-pushed
the
Update-isort-and-black-in-run_formatters-script-to-Ruff
branch
from
19edff9 to
597f811
Compare
Avasam
force-pushed
the
Update-isort-and-black-in-run_formatters-script-to-Ruff
branch
from
597f811 to
281984e
Compare
debonte
approved these changes
Mar 25, 2025
Avasam
deleted the
Update-isort-and-black-in-run_formatters-script-to-Ruff
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently I glanced over this file in previous PRs
I wouldn't really call "ruff check --fix" a formatter... Maybe I should rename the file to
run_hygieneto match the CI job name ?