cmos_rtc: Fix overflow found by fuzzer#3198
Merged
smalis-msft merged 2 commits intomicrosoft:mainfrom Apr 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a panic/overflow in the CMOS RTC device when converting extreme guest-programmed RTC register values into a UTC timestamp, folding the failure into existing error handling.
Changes:
- Replace a fallible
to_zoned(UTC).unwrap()conversion withResult-based propagation. - Continue using existing ratelimited warning + early return when RTC register contents are invalid/unrepresentable.
jstarks
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an overflow found by the fuzzer where extremely large times (year 9999) would hit this unwrap. Just fold it into the existing error handling instead.