-
Notifications
You must be signed in to change notification settings - Fork 36
FEAT: Add Azure SQL Database to PR validation pipeline matrix #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add AzureSQL matrix entry to Windows x64 job (Python 3.13) - Add AzureSQL matrix entry to macOS x86_64 job with Docker/Colima skip conditions - Add Debian_AzureSQL matrix entry to Linux x86_64 job - All entries gated on AZURE_CONNECTION_STRING pipeline variable being set - Azure SQL test steps use instead of localhost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Azure DevOps PR validation pipeline to optionally run the existing test suite against an Azure SQL Database in addition to the current LocalDB / local SQL Server / containerized SQL Server configurations.
Changes:
- Adds AzureSQL entries to the Windows, macOS, and Linux job matrices, intended to be enabled when
AZURE_CONNECTION_STRINGis set. - Skips Docker/Colima + SQL Server container startup steps when running the AzureSQL matrix leg(s).
- Runs pytest with Azure SQL connection settings and produces separate test/coverage outputs (Windows) and Azure-specific test steps (macOS/Linux).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.pybind.ddbc_bindings.cpp: 69.3%
mssql_python.pybind.ddbc_bindings.h: 69.7%
mssql_python.pybind.connection.connection.cpp: 75.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 84.1%
mssql_python.cursor.py: 84.7%🔗 Quick Links
|
c68611b to
336aeb0
Compare
Work Item / Issue Reference
Summary
This pull request updates the
eng/pipelines/pr-validation-pipeline.ymlfile to streamline Windows testing jobs and introduce new Azure SQL Database testing jobs for Windows, macOS, and Linux environments. The most significant changes are the removal of temporary CodeQL workarounds and the addition of cross-platform jobs for testing against Azure SQL Database.Azure SQL Database testing jobs (new functionality):
PytestOnWindows_AzureSQL,PytestOnMacOS_AzureSQL, andPytestOnLinux_AzureSQLjobs to run tests directly against Azure SQL Database, gated by theENABLE_AZURE_SQLvariable. These jobs set up dependencies, build bindings, execute tests, and publish results for each platform.Pipeline cleanup (removal of temporary workarounds):