igvm_defs, igvm: introduce corim measurement header#99
igvm_defs, igvm: introduce corim measurement header#99chris-oo wants to merge 10 commits intomicrosoft:mainfrom
Conversation
igvm_defs/src/lib.rs
Outdated
| /// A structure defining a CoRIM CBOR payload for a given platform. TODO: rename | ||
| /// to remove measurement? | ||
| /// | ||
| /// The payload described by this header is a CBOR CoRIM payload. There may only |
There was a problem hiding this comment.
Would be good to be have a similar level of detail here as below, pointing to section 4.1 of the spec, and explicitly calling it out as a tagged unsigned CoRIM map.
There was a problem hiding this comment.
How does the verbage look on the most recent iteration?
There was a problem hiding this comment.
I can't tell how much the wording has changed, but it still seems useful to add a short paragraph similar to what's on IGVM_VHS_CORIM_SIGNATURE, maybe something like:
This header describes a `tagged-unsigned-corim-map` as defined in section 4.1 of https://datatracker.ietf.org/doc/draft-ietf-rats-corim/.
(assuming here that the tagged-unsigned-corim-map is the one you're expecting)
Not a critical detail, of course, mostly for ease of traversing docs.
There was a problem hiding this comment.
Nope great feedback, I'll include a link for the document itself. We did for the signature, but good to be consistent.
|
CoRIM spec does not seem to support detached mode —- waiting for confirmation ietf-rats-wg/draft-ietf-rats-corim#514 |
|
There is a proposal to add detached mode support: ietf-rats-wg/draft-ietf-rats-corim#520 |
chris-oo
force-pushed
the
corim-header
branch
from
208a082 to
925441f
Compare
chris-oo
changed the title
4 participants
Introduce a CoRIM document and CoRIM signature header to allow CoRIM payloads to be described for a given platform. This is the bare-minimum support to start proving out CoRIM support for IGVM files, with more support tracked by #115.