Skip to content

Update build gates and testing to target Chromium for the PR gate#7316

Merged
janechu merged 15 commits intomainfrom
users/janechu/split-pr-workflow
Mar 17, 2026
Merged

Update build gates and testing to target Chromium for the PR gate#7316
janechu merged 15 commits intomainfrom
users/janechu/split-pr-workflow

Conversation

@janechu
Copy link
Collaborator

@janechu janechu commented Mar 13, 2026

Pull Request

📖 Description

Currently the PR required build gate tests on all browsers, this is overkill and this change limits it to just Chromium. The other browsers and operating systems will run on the separate pipeline to avoid slow build gate times.

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@radium-v
Copy link
Collaborator

Instead of splitting the playwright configs into separate cohorts, you could use --project flags, ex. playwright test --project=chromium to just run the "chromium" project config, or --project=* to run all projects https://playwright.dev/docs/test-cli#common-options

@janechu janechu self-assigned this Mar 16, 2026
Copy link
Collaborator

@radium-v radium-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will fail because fast-router doesn't have any projects defined in its playwright.config.ts. I created #7319 to address this by converting the router tests to use Node.

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
@janechu
Copy link
Collaborator Author

janechu commented Mar 17, 2026

I think this will fail because fast-router doesn't have any projects defined in its playwright.config.ts. I created #7319 to address this by converting the router tests to use Node.

I think this will fail because fast-router doesn't have any projects defined in its playwright.config.ts. I created #7319 to address this by converting the router tests to use Node.

Looks like we might have the same problem on the ssr package, could you convert those to Node tests your PR as well? Thanks for checking that out!

@radium-v radium-v self-requested a review March 17, 2026 15:41
@janechu janechu merged commit 6df43be into main Mar 17, 2026
12 checks passed
@janechu janechu deleted the users/janechu/split-pr-workflow branch March 17, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants