Add AI coding assistant instructions and TypeScript skill#7274
Add AI coding assistant instructions and TypeScript skill#7274
Conversation
chrisdholt
left a comment
There was a problem hiding this comment.
Do we need to be explicit to CLAUDE.md here or would Claude pickup either instructions or an Agents.md file?
According to the GitHub docs it may just be for that agent, since I used claude to generate the instructions it created the |
38abf94 to
d7083d0
Compare
|
@chrisdholt I've updated to the non-agent specific |
d63473c to
31493b0
Compare
Replace the Claude-specific CLAUDE.md with a generic .github/copilot-instructions.md that any AI coding assistant can use. Add TypeScript Key Rules section and Acceptance Checklist with required CI commands. Remove agent-specific frontmatter and duplicated checklist from .github/typescript/SKILL.md. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move TypeScript skill from .github/typescript/ to .github/skills/typescript/ and add a new contributing skill at .github/skills/contributing/. Update copilot-instructions.md to reference the new paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… into shipping skill
31493b0 to
9f8f4e1
Compare
.github/skills/typescript/SKILL.md
Outdated
| import { PropertyChangeNotifier, SubscriberSet } from "./notifier.js"; | ||
| ``` | ||
|
|
||
| ## Barrel exports (index.ts) |
There was a problem hiding this comment.
this needs to be removed, or reversed to discourage using barrel exports
Pull Request
📖 Description
Adds agent-agnostic AI coding assistant instructions for the FAST monorepo. This uses the standard
.github/copilot-instructions.mdlocation that any AI coding assistant can consume.What's included:
.github/copilot-instructions.md— Top-level instructions covering repository overview, packages, key rules, TypeScript key rules, common commands, and an acceptance checklist with required CI gates (npm run build,npm run test,npm run format:check,npm run checkchange)..github/typescript/SKILL.md— Detailed TypeScript patterns and conventions for the FAST monorepo (Web Component authoring, templates, styles, observables, DI, testing conventions, module/export conventions).👩💻 Reviewer Notes
.github/copilot-instructions.mdusing agent-agnostic language.copilot-instructions.mdonly (not duplicated inSKILL.md).📑 Test Plan
.github/copilot-instructions.mdis picked up by AI coding assistants (GitHub Copilot, Claude Code).github/typescript/SKILL.mdcontains detailed TypeScript patterns without agent-specific languageCLAUDE.mdexists at the repo root✅ Checklist
General
$ npm run change⏭ Next Steps
.github/<domain>/SKILL.mdfor other areas (e.g., testing, SSR) as needed.🤖 Generated with Claude Code