Skip to content

Limit tunnel IDs and names to 49 characters for DNS compliance#581

Open
plequere-ms wants to merge 4 commits intomainfrom
dev/plequere/03242026
Open

Limit tunnel IDs and names to 49 characters for DNS compliance#581
plequere-ms wants to merge 4 commits intomainfrom
dev/plequere/03242026

Conversation

@plequere-ms
Copy link
Collaborator

DNS specifications limit each label in a hostname to 63 characters. Tunnel URIs include the tunnel ID/name plus port and inspection suffixes:

  • Standard: https://<tunnel_id>-..devtunnels.ms
  • Inspection: https://<tunnel_id>--inspect..devtunnels.ms

To ensure tunnel URIs remain within the 63-character DNS label limit, tunnel IDs and names are now limited to 49 characters (63 - 6 for port - 8 for inspect).

Fixes # https://github.com/github/dev-tunnels-planning/issues/1676

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

DNS specifications limit each label in a hostname to 63 characters. Tunnel URIs include the tunnel ID/name plus port and inspection suffixes:
- Standard: https://<tunnel_id>-<port>.<region>.devtunnels.ms
- Inspection: https://<tunnel_id>-<port>-inspect.<region>.devtunnels.ms

To ensure tunnel URIs remain within the 63-character DNS label limit, tunnel IDs and names are now limited to 49 characters (63 - 6 for port - 8 for inspect).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants