Skip to content

fix: Update defaultAction for networkAcls for aifcu based on enablePrivateNetworking parameter#444

Open
Harsh-Microsoft wants to merge 1 commit intodevfrom
hb-psl-bug-36352
Open

fix: Update defaultAction for networkAcls for aifcu based on enablePrivateNetworking parameter#444
Harsh-Microsoft wants to merge 1 commit intodevfrom
hb-psl-bug-36352

Conversation

@Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request introduces improvements to the network access control logic for AI services, ensuring that when private networking is enabled, stricter access policies are applied. Additionally, it fixes a dependency ordering issue for DNS zones and updates template metadata.

Network access control improvements:

  • Changed the defaultAction in networkAcls for AI services to conditionally use 'Deny' when private networking is enabled, enhancing security by restricting access. (infra/main.bicep, infra/main.json) [1] [2]

Deployment dependency corrections:

  • Fixed the ordering of the openAI DNS zone dependency to ensure proper resource deployment sequencing. (infra/main.json)

Template metadata updates:

  • Updated the Bicep-generated template hash to reflect changes in the deployment template. (infra/main.json)

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant