fix: use except Exception and is not None in data_selection/utils.py#365
Open
harshadkhetpal wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: use except Exception and is not None in data_selection/utils.py#365harshadkhetpal wants to merge 1 commit intomicrosoft:mainfrom
harshadkhetpal wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Two PEP8/correctness fixes: 1. Replace bare `except:` with `except Exception:` on import guard 2. Replace `!= None` comparison with `is not None` (PEP8 E711)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two PEP8 / correctness fixes in
data_selection/utils.py:Bare
except:→except Exception:— The import guard fortransformers.mpuused a bareexcept:which silently catchesKeyboardInterruptandSystemExit. Since there is no re-raise,except Exception:is the correct choice — it catches all regular import errors while letting system signals propagate.!= None→is not None— PEP8 E711: comparisons toNoneshould always useis/is not, not==/!=.Changes:
Testing
No behavior change — style/correctness fixes only.