Convert to proper npm library package (resolves #118)#145
Open
Frostfire25 wants to merge 1 commit intomicrosoft:mainfrom
Open
Convert to proper npm library package (resolves #118)#145Frostfire25 wants to merge 1 commit intomicrosoft:mainfrom
Frostfire25 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Frostfire25
commented
Mar 18, 2026
Frostfire25
commented
- Fix .npmignore: remove /dist exclusion so compiled output ships with package
- Add files whitelist in package.json for explicit publish control
- Rename package to @microsoft/fluentui-editable-grid with public access
- Widen peerDependencies to support React 17, 18, and 19
- Replace Windows-only build scripts with cross-platform cross-env/rimraf/mkdirp
- Add CI workflow (build + verify on Node 16/18/20)
- Add publish workflow (npm publish on GitHub Release)
Frostfire25
force-pushed
the
alexandere-elguezabal/npm-library-packaging
branch
from
92533fc to
fb3b523
Compare
Frostfire25
force-pushed
the
alexandere-elguezabal/npm-library-packaging
branch
from
fb3b523 to
eca91df
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the project to behave like a publishable npm library package (scoped name, explicit publish contents, cross-platform build scripts) and adds GitHub Actions workflows for CI and npm publishing.
Changes:
- Update
package.jsonfor scoped/public publishing, explicitfileswhitelist, wider React peer dependency range, and cross-platform build scripts. - Ensure
dist/is publishable by adjusting.npmignore. - Add CI workflow (Node 16/18/20) and release-based publish workflow to npm.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Scoped package name, publish config/files whitelist, peerDependency range updates, and cross-platform build tooling/scripts. |
.npmignore |
Allows dist/ to be included in published package. |
.gitignore |
Adds package-lock.json to ignored files. |
.github/workflows/ci.yml |
New CI workflow to build/verify output and inspect packed contents. |
.github/workflows/publish.yml |
New release-triggered workflow to build/verify and publish to npm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+55
to
61
| "cross-env": "^7.0.3", | ||
| "immer": ">=9.0.6", | ||
| "just-scripts": "^0.27.0", | ||
| "just-stack-react": "^1.0.0", | ||
| "marked": ">=4.0.10", | ||
| "mkdirp": "^3.0.1", | ||
| "nth-check": ">=2.0.1", |
Comment on lines
+20
to
+24
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
| - name: Install dependencies |
Comment on lines
+19
to
+23
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| registry-url: https://registry.npmjs.org | ||
|
|
| echo "✅ dist/ output verified" | ||
|
|
||
| - name: Publish to npm | ||
| run: npm publish --provenance --access public |
- Fix .npmignore: remove /dist exclusion so compiled output ships with package - Add files whitelist in package.json for explicit publish control - Rename package to @microsoft/fluentui-editable-grid with public access - Widen peerDependencies to support React 17, 18, and 19 - Replace Windows-only build scripts with cross-platform cross-env/rimraf/mkdirp - Add CI workflow (build + verify on Node 16/18/20) - Add publish workflow (npm publish on GitHub Release) - Remove package-lock.json from version control (library best practice) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Frostfire25
force-pushed
the
alexandere-elguezabal/npm-library-packaging
branch
from
eca91df to
4704e8e
Compare
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.