Prevent primary keys from being flagged by "Hide foreign" keys rule#371
Open
emil-eklund wants to merge 1 commit intomicrosoft:masterfrom
Open
Prevent primary keys from being flagged by "Hide foreign" keys rule#371emil-eklund wants to merge 1 commit intomicrosoft:masterfrom
emil-eklund wants to merge 1 commit intomicrosoft:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the "Hide foreign keys" BPA rule that was incorrectly flagging primary keys in addition to foreign keys. The issue occurred because the rule only checked if a column name matched the FromColumn name in any relationship with "Many" cardinality, without verifying that the column actually belonged to the FromTable (many-side) of the relationship.
Changes:
- Updated the HIDE_FOREIGN_KEYS rule expression to add a table name check, ensuring only foreign keys (not primary keys with the same column name) are flagged
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234
Very noticeable in agentic workloads where primary keys are often hidden without regard for legitimate use-cases.