Fix validate deployenabled types#52
Open
Chandraveersingh1717 wants to merge 3 commits intometacall:masterfrom
Open
Fix validate deployenabled types#52Chandraveersingh1717 wants to merge 3 commits intometacall:masterfrom
Chandraveersingh1717 wants to merge 3 commits intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validate() and deployEnabled() methods were returning Promise, but according to swagger.yaml they actually return a ServiceInfo object with service metadata (id, name, version, organization, etc).
This caused type mismatches where users couldn't access the actual response data. Added the ServiceInfo interface and updated both methods to return the correct type.
Changes:
All tests passing.