Skip to content

Improve code quality#51

Open
Chandraveersingh1717 wants to merge 2 commits intometacall:masterfrom
Chandraveersingh1717:improve-code-quality
Open

Improve code quality#51
Chandraveersingh1717 wants to merge 2 commits intometacall:masterfrom
Chandraveersingh1717:improve-code-quality

Conversation

@Chandraveersingh1717
Copy link

Fix a few type and code quality issues:

  • Corrected the Branches interface to use string[] instead of a single-element tuple [string]
  • Replaced loose equality (==) with strict equality (===) in inspectByName
  • Fixed ready() to return the boolean response body (res.data) instead of checking the HTTP status code
  • Replaced the infinite loop (for(;;)) in waitFor with a clearer while loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant