fix: add error handling for multipart upload parsing#108
Closed
Priyanshu-u07 wants to merge 1 commit intometacall:masterfrom
Closed
fix: add error handling for multipart upload parsing#108Priyanshu-u07 wants to merge 1 commit intometacall:masterfrom
Priyanshu-u07 wants to merge 1 commit intometacall:masterfrom
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
Contributor
Author
|
@HeeManSu |
|
@Priyanshu-u07 tests are failing please can you check them. |
Open
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the FaaS received a malformed multipart upload due to the axios upgrade, busboy threw an unhandled error event which crashed the entire server process. Added proper error handling to fix this.
Related issue
Fixes #106
Notes for reviewers
This PR depends on the protocol PR (metacall/protocol#48). The protocol fix must be merged and published to npm first, otherwise the integration tests will continue to fail due to the FormData boundary mismatch