Feat/implicit ignore files#216
Open
Chandraveersingh1717 wants to merge 3 commits intometacall:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when deploying a directory using
metacall-deploy, users must manually pass-I/--ignoreflags to exclude unnecessary folders such asnode_modulesor.git. If these flags are missed, large folders may be included in the deployment archive, increasing upload size and deployment time.This PR improves the developer experience by automatically reading ignore rules from
.gitignoreand.metacallignoreduring deployment.Changes
Automatic Ignore Loading
Reads
.gitignoreand.metacallignorefrom the project root during deployment.Ignore Parsing
Safely ignores empty lines and comment lines (
#).Deduplication
Combines CLI
--ignoreflags with ignore files usingSetto avoid duplicate patterns.Refactor
Removed a shadowed
descriptorvariable and improved handling of potential TypeScript edge cases.Type of Change
Testing
.gitignoreand.metacallignorenpm run build,npm run lint)