feat: add Ctrl+C cancel hint to persistent screens and Exit option to list prompts#200
Draft
Swastik-Prakash1 wants to merge 1 commit intometacall:masterfrom
Draft
feat: add Ctrl+C cancel hint to persistent screens and Exit option to list prompts#200Swastik-Prakash1 wants to merge 1 commit intometacall:masterfrom
Swastik-Prakash1 wants to merge 1 commit intometacall:masterfrom
Conversation
… list prompts - Show 'Press Ctrl+C to cancel' at bottom of inspect table (persistent loop) - Show 'Press Ctrl+C to cancel' in logs output (persistent while loop) - Add 'Exit' option to loginSelection, planSelection, listSelection prompts - Follows maintainer feedback from PR metacall#173 Fixes metacall#154
Author
|
Member
|
@Swastik-Prakash1 can you show how the exit option looks? I see you have also added exit options. |
Author
Here's how the Exit option looks on the login selection screen. Same pattern applies to plan selection and deployment list screens. Let me know if you'd like any changes!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #154 based on maintainer feedback from the closed PR #173.
Changes
src/cli/inspect.ts: ShowsPress Ctrl+C to cancelat the bottom ofthe persistent table loop (the
for(;;)loop that refreshes every 5s)src/logs.ts: ShowsPress Ctrl+C to cancelin the persistent logsloop (the
whileloop that polls until status = ready)src/cli/selection.ts: Adds an "Exit" option to list-type prompts(login, plan, container selection) for graceful exit without Ctrl+C
Approach
Based on @viferga's review on #173:
Fixes #154