Adding state parser utility that can be used for retrieving and modifying worker states#1278
Adding state parser utility that can be used for retrieving and modifying worker states#1278gokulavasan wants to merge 1 commit intomainfrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1278
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cb10f71 with merge base 958eeb0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class StateParserUtil: |
There was a problem hiding this comment.
can we keep these as functions? I'm not sure of the benefit of having a class here
andrewkho
left a comment
There was a problem hiding this comment.
I think pure functions are easier to reason about and harder to screw up, let me know if there's other reasons you want to keep them in a class
|
Hi @gokulavasan! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary: Allows users to get the worker states out of the state dict. It can be used if users want to modify the state offline. Starts off with very preliminary set of methods aimed at supporting usecases where number of workers need to change.
Test Plan: Unit tests
Reviewers:
Subscribers:
Tasks:
Tags:
Please read through our contribution guide prior to
creating your pull request.
Fixes #{issue number}
Changes