Refactor the Meshtastic TCP pub/sub example to ensure proper resource cleanup and clearer exception handling.#899
Open
dim5x wants to merge 1 commit intomeshtastic:masterfrom
Open
Refactor the Meshtastic TCP pub/sub example to ensure proper resource cleanup and clearer exception handling.#899dim5x wants to merge 1 commit intomeshtastic:masterfrom
dim5x wants to merge 1 commit intomeshtastic:masterfrom
Conversation
… cleanup and clearer exception handling.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
TCPInterface.close()is always called.ifaceto None to safely handle failures during interface creation.sys.exit(1)with re-raising the exception to preserve the original traceback.TCPInterfacedirectly.Why:
iface.close()due to the infinite loop and could leave the TCP connection open when interrupted or when an exception occurred.Behavior impact: