Make sleep longer and universal to fix config restore#829
Open
interfect wants to merge 1 commit intomeshtastic:masterfrom
Open
Make sleep longer and universal to fix config restore#829interfect wants to merge 1 commit intomeshtastic:masterfrom
interfect wants to merge 1 commit intomeshtastic:masterfrom
Conversation
This should fix meshtastic#575 and also fix meshtastic#576.
ianmcorvidae
reviewed
Nov 6, 2025
| # When config restore can handle and recover from dropped | ||
| # packets, or rate-limit based on acknowledgements, we can | ||
| # remove this. | ||
| time.sleep(2.0) |
Contributor
There was a problem hiding this comment.
This seems like a very heavy change since it'll apply to all writes on serial and TCP both, and not just configuration. Would it work to increase the sleeps in the handling for --configure specifically (and perhaps --export-config too if needed), rather than adding a forced delay to all interactions with the radio?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #575 and also fix #576.
At least for the boards I have and a local serial connection. Other boards may need to be fed data even more slowly, and config restore over the mesh really can't avoid handling a lost packet and either resending it or knowing to fail the transaction.