Merged
Conversation
syauqimekari
requested review from
TjandraD,
kevinemilio-mkr and
philiplambok-mekari
| return [] unless merchants | ||
|
|
||
| merchants.map do |merchant_data| | ||
| MerchantItem.new(merchant_data) |
Contributor
There was a problem hiding this comment.
hmn, ini modelnya gak inheret dri model base? kalo ada penambahan attribute di API response ada kemungkinan bakal error ini @syauqimekari, bisa coba tambahin test case ini gak?
| end | ||
|
|
||
| # Inner class to represent individual merchant items | ||
| class MerchantItem |
Contributor
There was a problem hiding this comment.
kalo ini dibuat file baru aja gimana? gk perlu di define di model dalem class get, wdyt?
| class Get < MidtransApi::Model::Base | ||
| resource_attributes :merchants | ||
|
|
||
| def resolve_params_attr(attr) |
Contributor
There was a problem hiding this comment.
ini buat apa ya ki?
Contributor
Author
There was a problem hiding this comment.
ini udah standard dari base modelnya bang untuk parsenya
philiplambok-mekari
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.