fix(openclaw): make verify fail on unhealthy backend#84
Open
MatrixAdventurer wants to merge 1 commit intomatrixorigin:mainfrom
Open
fix(openclaw): make verify fail on unhealthy backend#84MatrixAdventurer wants to merge 1 commit intomatrixorigin:mainfrom
MatrixAdventurer wants to merge 1 commit intomatrixorigin:mainfrom
Conversation
Contributor
Author
|
For broader project context, this work lives in the Memoria repo itself: |
Contributor
Author
|
Quick maintenance note: the implementation/result still looks useful, but this branch is now dirty against current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openclaw memoria verifyrun a realopenclaw memoria healthcheck before reporting successWhy
I hit a local false-positive case where
verifyreturnedok: trueeven though the configured Memoria backend was not healthy and normal memory operations were already failing at runtime.That made
verifygood at checking install wiring, but not good enough at answering the practical question users care about: "is this setup actually usable right now?"This change makes
verifya better post-install / post-setup diagnostic by requiring a successful health check before it reports success.What changed
verify_plugin_install.mjsopenclaw memoria health --user-id ...as part of verificationembeddingProvider=local: remind users that the binary must be built withlocal-embeddingLocal testing
Passed locally:
node --check plugins/openclaw/scripts/connect_openclaw_memoria.mjsnode --check plugins/openclaw/scripts/verify_plugin_install.mjsconnect_openclaw_memoria.mjswrites the expected cloud config)verify_plugin_install.mjsnow exits non-zero with health details and hints instead of returningok: true