Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extracted duplicate pick-status and winner-comparison logic into a shared
Bracket::Service::PickStatusservice, and switched Region/Final4/Admin code paths to consume it.Why
Region,Final4, andAdmin::player_pointseach reimplemented the samein/out/pendingwinner checks with small variations. That made behavior drift more likely and multiplied query overhead/maintenance cost.How
Added
PickStatushelpers for loading player picks, building pick maps, loading perfect-winner picks, and classifying each pick asin,out, orpending.Replaced duplicated loops in
Region::view,Final4::make,Final4::view, andAdmin::player_pointswith service calls while preserving existing scoring formulas and templates.Added a DB-backed
t/pick_status.tto lock service behavior.Testing
script/test-env.sh prove -lv t/pick_status.t t/controller_Region.t t/bracket_validator.tscript/test-env.sh prove -lr tQuality Report
Changes: 5 files changed, 151 insertions(+), 129 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline